Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy 2.0 compability #6238

Merged
merged 14 commits into from
May 23, 2024
Merged

Numpy 2.0 compability #6238

merged 14 commits into from
May 23, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 18, 2024

No description provided.

@hoxbro hoxbro added the type: compatibility Compability with upstream packages label May 18, 2024
@hoxbro hoxbro added this to the 1.19.0 milestone May 18, 2024
@hoxbro hoxbro mentioned this pull request May 18, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented May 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.38%. Comparing base (945e179) to head (31155be).
Report is 3 commits behind head on main.

Files Patch % Lines
holoviews/tests/core/test_dimensions.py 75.00% 1 Missing ⚠️
...oloviews/tests/element/test_comparisondimension.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6238      +/-   ##
==========================================
- Coverage   88.39%   88.38%   -0.01%     
==========================================
  Files         323      323              
  Lines       67620    67630      +10     
==========================================
+ Hits        59770    59778       +8     
- Misses       7850     7852       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hoxbro
hoxbro commented May 18, 2024
View reviewed changes
holoviews/core/sheetcoords.py Outdated Show resolved Hide resolved
@hoxbro hoxbro requested a review from philippjfr May 20, 2024 10:27
@hoxbro hoxbro changed the title Test Numpy 2.0 and updates Numpy 2.0 compability May 23, 2024
@hoxbro hoxbro merged commit 6b0121d into main May 23, 2024
@hoxbro hoxbro deleted the numpy2 branch May 23, 2024 15:03
@rgommers rgommers mentioned this pull request Jun 25, 2024
Open
@jakirkham jakirkham mentioned this pull request Jun 25, 2024
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
1 participant
@hoxbro